Improve speed of sshd tree-sitter grammar#1551
Open
SteveL-MSFT wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Performance optimization for the sshd tree-sitter grammar by reducing parser ambiguity and inlining hot rules. The _commaSeparatedString rule (which required at least one comma) is merged into a single _stringArg rule that handles both single and comma-separated strings via repeat, eliminating the need for a separate $.string alternative in _argument. Explicit precedence between boolean, number, and string plus inlining _new_line/_argument reportedly improves parse rates by ~60-80%.
Changes:
- Add
inlinefor_new_lineand_argument, and aprecedencesdeclaration orderingboolean > number > stringto resolve token conflicts. - Replace
_commaSeparatedString(requiringrepeat1) with_stringArgusingrepeat, so it now subsumes the bare$.stringbranch in_argument. - Flatten a redundant nested
seqin thematchrule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Simplify match to give speed improvement. Before changes:
After, still have warning on slow parse rate, but significant improvement: