chore: add Sentry license attribution#164
Merged
Merged
Conversation
Contributor
Prompt To Fix All With AIFix the following 5 code review issues. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 5
LICENSE:25-26
The copyright holder name appears to be missing "Functional". Other Sentry SDK repositories (e.g. `sentry-go`) use **"Functional Software, Inc. dba Sentry"** as the full legal entity name. Dropping "Functional" may result in an inaccurate attribution.
```suggestion
Some files in this codebase contain code from getsentry/sentry-ruby by Functional Software, Inc. dba Sentry.
In such cases it is explicitly stated in the file header. This license only applies to the relevant code in such cases.
```
### Issue 2 of 5
LICENSE:30
The copyright year in the Sentry block is 2020, but the sentry-ruby repository was created in 2018 and other Sentry SDK licenses use earlier years. Worth double-checking against the actual `getsentry/sentry-ruby` LICENSE file to ensure the year is accurate.
```suggestion
Copyright (c) 2018 Sentry
```
### Issue 3 of 5
posthog-rails/lib/posthog/rails/configuration.rb:3
Same company name issue as in the LICENSE file — "Functional" appears to be missing from the attribution.
```suggestion
# Portions of this file are derived from getsentry/sentry-ruby by Functional Software, Inc. dba Sentry
```
### Issue 4 of 5
posthog-rails/lib/posthog/rails/parameter_filter.rb:3
Same company name issue as in the LICENSE file — "Functional" appears to be missing from the attribution.
```suggestion
# Portions of this file are derived from getsentry/sentry-ruby by Functional Software, Inc. dba Sentry
```
### Issue 5 of 5
posthog-rails/lib/posthog/rails/rescued_exception_interceptor.rb:3
Same company name issue as in the LICENSE file — "Functional" appears to be missing from the attribution.
```suggestion
# Portions of this file are derived from getsentry/sentry-ruby by Functional Software, Inc. dba Sentry
```
Reviews (1): Last reviewed commit: "chore: add Sentry license attribution" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+25
to
+26
| Some files in this codebase contain code from getsentry/sentry-ruby by Software, Inc. dba Sentry. | ||
| In such cases it is explicitly stated in the file header. This license only applies to the relevant code in such cases. |
Contributor
There was a problem hiding this comment.
sentry-go) use "Functional Software, Inc. dba Sentry" as the full legal entity name. Dropping "Functional" may result in an inaccurate attribution.
Suggested change
| Some files in this codebase contain code from getsentry/sentry-ruby by Software, Inc. dba Sentry. | |
| In such cases it is explicitly stated in the file header. This license only applies to the relevant code in such cases. | |
| Some files in this codebase contain code from getsentry/sentry-ruby by Functional Software, Inc. dba Sentry. | |
| In such cases it is explicitly stated in the file header. This license only applies to the relevant code in such cases. |
Prompt To Fix With AI
This is a comment left during a code review.
Path: LICENSE
Line: 25-26
Comment:
The copyright holder name appears to be missing "Functional". Other Sentry SDK repositories (e.g. `sentry-go`) use **"Functional Software, Inc. dba Sentry"** as the full legal entity name. Dropping "Functional" may result in an inaccurate attribution.
```suggestion
Some files in this codebase contain code from getsentry/sentry-ruby by Functional Software, Inc. dba Sentry.
In such cases it is explicitly stated in the file header. This license only applies to the relevant code in such cases.
```
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
|
||
| MIT License | ||
|
|
||
| Copyright (c) 2020 Sentry |
Contributor
There was a problem hiding this comment.
getsentry/sentry-ruby LICENSE file to ensure the year is accurate.
Suggested change
| Copyright (c) 2020 Sentry | |
| Copyright (c) 2018 Sentry |
Prompt To Fix With AI
This is a comment left during a code review.
Path: LICENSE
Line: 30
Comment:
The copyright year in the Sentry block is 2020, but the sentry-ruby repository was created in 2018 and other Sentry SDK licenses use earlier years. Worth double-checking against the actual `getsentry/sentry-ruby` LICENSE file to ensure the year is accurate.
```suggestion
Copyright (c) 2018 Sentry
```
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| @@ -1,5 +1,8 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| # Portions of this file are derived from getsentry/sentry-ruby by Software, Inc. dba Sentry | |||
Contributor
There was a problem hiding this comment.
Suggested change
| # Portions of this file are derived from getsentry/sentry-ruby by Software, Inc. dba Sentry | |
| # Portions of this file are derived from getsentry/sentry-ruby by Functional Software, Inc. dba Sentry |
Prompt To Fix With AI
This is a comment left during a code review.
Path: posthog-rails/lib/posthog/rails/configuration.rb
Line: 3
Comment:
Same company name issue as in the LICENSE file — "Functional" appears to be missing from the attribution.
```suggestion
# Portions of this file are derived from getsentry/sentry-ruby by Functional Software, Inc. dba Sentry
```
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| @@ -1,5 +1,8 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| # Portions of this file are derived from getsentry/sentry-ruby by Software, Inc. dba Sentry | |||
Contributor
There was a problem hiding this comment.
Suggested change
| # Portions of this file are derived from getsentry/sentry-ruby by Software, Inc. dba Sentry | |
| # Portions of this file are derived from getsentry/sentry-ruby by Functional Software, Inc. dba Sentry |
Prompt To Fix With AI
This is a comment left during a code review.
Path: posthog-rails/lib/posthog/rails/parameter_filter.rb
Line: 3
Comment:
Same company name issue as in the LICENSE file — "Functional" appears to be missing from the attribution.
```suggestion
# Portions of this file are derived from getsentry/sentry-ruby by Functional Software, Inc. dba Sentry
```
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| @@ -1,5 +1,8 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| # Portions of this file are derived from getsentry/sentry-ruby by Software, Inc. dba Sentry | |||
Contributor
There was a problem hiding this comment.
Suggested change
| # Portions of this file are derived from getsentry/sentry-ruby by Software, Inc. dba Sentry | |
| # Portions of this file are derived from getsentry/sentry-ruby by Functional Software, Inc. dba Sentry |
Prompt To Fix With AI
This is a comment left during a code review.
Path: posthog-rails/lib/posthog/rails/rescued_exception_interceptor.rb
Line: 3
Comment:
Same company name issue as in the LICENSE file — "Functional" appears to be missing from the attribution.
```suggestion
# Portions of this file are derived from getsentry/sentry-ruby by Functional Software, Inc. dba Sentry
```
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
ioannisj
approved these changes
Jun 3, 2026
hpouillot
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Add explicit attribution for portions of the codebase derived from getsentry/sentry-ruby and include the relevant Sentry MIT license text in the repository license file.
💚 How did you test it?
git diff --checkruby -c posthog-rails/lib/posthog/rails/configuration.rbruby -c posthog-rails/lib/posthog/rails/parameter_filter.rbruby -c posthog-rails/lib/posthog/rails/rescued_exception_interceptor.rb📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset file