feat: emit $is_server property on captured events#163
Merged
Conversation
Contributor
|
Reviews (1): Last reviewed commit: "feat: emit $is_server property on captur..." | Re-trigger Greptile |
dustinbyrne
reviewed
Jun 3, 2026
Comment on lines
+343
to
344
| attrs[:is_server] = @is_server | ||
| enqueue(FieldParser.parse_for_group_identify(attrs)) |
Contributor
There was a problem hiding this comment.
FieldParser.parse_for_group_identify writes attrs to an inner $group_set property instead of a top level property, so this won't work
Contributor
There was a problem hiding this comment.
worth testing the shape of these enqueued events to catch this
dustinbyrne
approved these changes
Jun 3, 2026
| { | ||
| event: '$groupidentify', | ||
| properties: { | ||
| properties: (common[:properties] || {}).merge( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
$is_server: trueto every event captured by this SDK so PostHog ingestion can identify server-side events.