Keeps Stokes throughout postprocessing#353
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #353 +/- ##
=========================================
+ Coverage 6.27% 6.28% +0.01%
=========================================
Files 38 38
Lines 15242 15209 -33
Branches 3664 3654 -10
=========================================
Hits 956 956
+ Misses 14272 14239 -33
Partials 14 14 ☔ View full report in Codecov by Harness. |
b568bf3 to
0f10a71
Compare
e74b32b to
e08d892
Compare
low-sky
approved these changes
Jun 24, 2026
This PR fixes the unnecessary slowdowns that come with re-adding degenerate axes throughout postprocessing. CASA now typically crashes if the images don't have 4 axes in, which it didn't use to. So we now spend a lot of time ripping them out and putting them back in, which can take a long time for big cubes. Now, we just keep the Stokes axis in throughout, dropping when we export to fits at the end. This also finally fixes the feather/feather_before_mosaic logic. Now, if feather is True and feather_before_mosaic is False, it will feather together individual mosaic tiles, as well as mosaicking the interferometric and singledish data before feathering those together for the final mosaic of mosaics. If feather_before mosaic is True, then it will instead mosaic together the feathered individual tiles. Note that if feather_before_mosaic is True, it will still create the full singledish image, but will not use this for the final mosaic. - Fix bug with has_memory_issue call - Ensure coordinate axes between interferometric/singledish data match up when staging in postprocessing - Fix pixperbeam in trim cube to actually respect min_pixperbeam - Remove dropdegaxes calls, since we don't use them any more - ccr_dropdeg has now been renamed to ccr_importfits, and modified to either import a fits file or just copy over - Fix logic with feather_before_mosaic
e08d892 to
a397fbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the unnecessary slowdowns that come with re-adding degenerate axes throughout postprocessing.
CASA now typically crashes if the images don't have 4 axes in, which it didn't use to. So we now spend a lot of time ripping them out and putting them back in, which can take a long time for big cubes. Now, we just keep the Stokes axis in throughout, dropping when we export to fits at the end.
This also finally fixes the feather/feather_before_mosaic logic:
Fixes: