feat: add setup-deterministic-zip with pinned, checksum-verified install#91
Closed
nathanklick wants to merge 1 commit into
Closed
feat: add setup-deterministic-zip with pinned, checksum-verified install#91nathanklick wants to merge 1 commit into
nathanklick wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new opt-in installer step to this composite action for timo-reymann/deterministic-zip, using a pinned version and hard-coded per-platform SHA-256 verification (fail-closed) prior to installation—aligning with the repo’s existing “pinned + checksummed install” approach for other tools.
Changes:
- Add a new
setup-deterministic-zipinput to toggle installation. - Implement a pinned
deterministic-zipdownload + hard-coded SHA-256 verification + install to/usr/local/bin. - Document the new input and usage example in the README.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Documents the new setup-deterministic-zip input and adds a usage example. |
| action.yml | Adds the new input and implements the pinned, checksum-verified deterministic-zip installation step. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add an opt-in setup-deterministic-zip installer that fetches timo-reymann/deterministic-zip at a pinned version (1.2.0) and verifies the release asset against a hard-coded per-platform SHA-256 before installing it, failing closed on mismatch. The release's own .sha256 sidecars are intentionally not trusted, since an upstream asset swap would replace them alongside the binary. Mirrors the existing pinned+checksummed jq/gomplate/semver steps. Consumers can drop inline, unverified 'curl | sudo install' patterns. Signed-off-by: Nathan Klick <nathan@theklickfamily.com>
nathanklick
force-pushed
the
fix/pin-checksum-deterministic-zip
branch
from
July 16, 2026 01:21
ccd0ae0 to
0badaba
Compare
Collaborator
Author
|
Superseded by #92, which opens the same GPG-signed commit directly on upstream instead of from a fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an opt-in
setup-deterministic-zipinstaller that fetchestimo-reymann/deterministic-zipat a pinned version (1.2.0) and verifies the release asset against a hard-coded per-platform SHA-256 before installing it, failing closed on mismatch. It follows the same pattern as the existing pinned+checksummedsetup-jq,setup-gomplate, andsetup-semversteps.Why
Consumers currently install deterministic-zip inline with an unpinned, unverified pattern:
A mutable release tag with no integrity check means an upstream asset swap silently executes attacker-controlled code in the release path. This mirrors the
semversupply-chain issue fixed in #90 / v1.2.2; this change lets consumers drop the inlinecurl | sudo installand opt in withsetup-deterministic-zip: 'true'instead.Design note
The release ships its own
<asset>.sha256sidecars, but those are not trusted here — a release-asset swap would replace the sidecar alongside the binary. The expected digests are hard-coded (assemverdoes), so any tamper fails closed. Supports Linux/macOS on amd64/arm64; bump instructions are in the step's env comment.Verification
Digests baked in were reproduced from the 1.2.0 release assets, e.g.
deterministic-zip_linux-amd64→56e9c2e28c9f535f100df1a94df122b62f4f2f66300abde2cf68d6a236ee5eaa. A one-byte tamper changes the digest andshasum -a 256 -c -exits non-zero, aborting the step before install.README updated with the new input and a usage note.