fix: sync paddle patch#3
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR syncs a patch from the Paddle repository to avoid maintaining a downstream re-patch, touching low-level numeric conversion code and Linux network/ethtool plumbing.
Changes:
- Updates
cpu_half2floatimplementation ingloo/types.h. - Adjusts TCP device hostname handling includes (adds
<array>). - Modifies the
ETHTOOL_GLINKSETTINGSrequest buffer layout ingloo/common/linux.cc.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| gloo/types.h | Changes how half-precision values are converted to float on CPU. |
| gloo/transport/tcp/device.cc | Adds missing <array> include for std::array hostname buffer usage. |
| gloo/common/linux.cc | Alters the in-memory layout of the ioctl request buffer for ETHTOOL_GLINKSETTINGS. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
321
to
+323
| unsigned temp = ((sign << 31) | (exponent << 23) | mantissa); | ||
|
|
||
| void* rp = &temp; | ||
| return *(float*)rp; | ||
| return (float)temp; |
Comment on lines
189
to
193
| constexpr auto link_mode_data_nwords = 3 * 127; | ||
| struct { | ||
| struct ethtool_link_settings req; | ||
| __u32 link_mode_data[link_mode_data_nwords]; | ||
| struct ethtool_link_settings req; | ||
| } ecmd; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix