fix: gcc 15 build, include <cstdint>#2
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a GCC 15 build failure by making gloo/types.h explicitly include <cstdint>, ensuring fixed-width integer types (e.g., uint8_t, uint32_t, uint64_t) are available without relying on transitive includes.
Changes:
- Add
#include <cstdint>togloo/types.hto satisfy direct dependency on fixed-width integer type definitions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
本 PR 修复 GCC 15 下的构建问题，在
gloo/types.h中补充直接依赖的<cstdint>头文件。Changes
gloo/types.h中添加#include <cstdint>。background
gloo/types.h使用了固定宽度整数类型，但此前没有直接包含<cstdint>。GCC 15 下该依赖不再能稳定通过其他头文件间接获得，因此会暴露缺失头文件导致的编译失败。相关链接：