fix: superiorskyblock2 permission hook#265
Merged
Merged
Conversation
Contributor
Author
|
Tested on my production server as well, and the issue has been fixed |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the SuperiorSkyblock2 protection hook initialization so each required privilege is registered/loaded independently, addressing cases where one privilege already exists but the other doesn’t initialize properly.
Changes:
- Refactors privilege setup to resolve/register
spawner_stackandspawner_open_menuseparately. - Introduces a helper method to centralize privilege lookup/registration logic.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+35
to
+40
| SPAWNER_STACK = getOrRegisterPrivilege(SPAWNER_STACK_PERM); | ||
| SPAWNER_OPEN_MENU = getOrRegisterPrivilege(SPAWNER_OPEN_MENU_PERM); | ||
| registered = true; | ||
| } | ||
|
|
||
| private static IslandPrivilege getOrRegisterPrivilege(String name) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed an issue where if one permsision already exist, the other permission does not work and wont initialize. therefore i've changed of it register one permission at a time instead at the same time