chore: remove 5 unused npm dependencies#537
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
Remove dependencies with zero imports/usage in the codebase: Dependencies: - gpt-tokenizer (no imports, token counting was removed) - @tauri-apps/plugin-dialog (no JS or Rust usage, no capabilities) - @radix-ui/react-avatar (only used in dead avatar.tsx file) DevDependencies: - @noble/curves (zero imports, only a devDep of @opensecret/react) - @tanstack/router-devtools (zero imports, not auto-loaded) Also removes the dead src/components/ui/avatar.tsx file which was the sole consumer of @radix-ui/react-avatar and itself never imported. Co-Authored-By: tony@opensecret.cloud <TonyGiorgio@protonmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Deploying maple with
|
| Latest commit: |
3797ce8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c6afb577.maple-ca8.pages.dev |
| Branch Preview URL: | https://devin-1779515027-remove-unus.maple-ca8.pages.dev |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
Author
Smoke Test ResultsTested locally via Test Results (3/3 passed)
Console shows only normal SSE events and attestation logs. No errors related to removed packages ( Screenshots
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes 5 npm dependencies with zero imports/usage in the codebase, identified using
knipstatic analysis and manually verified via codebase-wide searches of imports, configs, scripts, Rust code, and Tauri capabilities.Dependencies removed:
gpt-tokenizer— zero imports (token counting feature was removed)@tauri-apps/plugin-dialog— no JS imports, no Rust usage, no capability permissions@radix-ui/react-avatar— only imported inavatar.tsxwhich itself is never importedDevDependencies removed:
@noble/curves— zero imports; codebase uses@noble/hashes(separate package)@tanstack/router-devtools— zero imports, not auto-loaded by router pluginAlso removes the dead
src/components/ui/avatar.tsxfile (sole consumer of@radix-ui/react-avatar, never imported anywhere).Verified safe:
just lint,just build(typecheck + vite build) all pass cleanly.Review & Testing Checklist for Human
just dev) and app loads without console errorsjust desktop-buildor equivalent)Notes
@tauri-apps/plugin-deep-link,@tauri-apps/plugin-fs, and@tauri-apps/clibut these are needed — deep-link and fs are used in Rust code + capabilities, and cli is the Tauri build tooluuidas replaceable with nativecrypto.randomUUID()but that requires code changes (not a free removal)bun removehandles the cleanup atomicallyLink to Devin session: https://app.devin.ai/sessions/181f5f2b929d495e8aa692fa8ecb0036
Requested by: @AnthonyRonning