fix: execute script mode IF and Python helpers - #51
Open
kocaemre wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_dsl_ifimplementation so DSLIFblocks use the existing block-aware control-flow handler.ELSE, and skipELSEbodies after a true branch.CALL/EMIThelper tasks so plain scripts likeCALL(...)andEMIT(...)actually execute.IF/ELSE, PythonCALL, and PythonEMIT.Fixes #50.
Test plan
test_dsl_if_false_skips_to_else_branchtest_python_call_helper_executes_device_actiontest_python_emit_helper_executes_eventpython3 -m pytest tests/logic/modes/test_script_mode_logic.py -q— 6 passedpython3 -m pytest tests/logic/modes -q— 76 passed, 4 existing warningspython3 -m pytest tests/logic -q— 563 passed, 1 skipped, 20 existing warningspython3 -m py_compile custom_components/opengrowbox/OGBController/managers/OGBScriptMode.py tests/logic/modes/test_script_mode_logic.pygit diff --check