Skip to content

Added optional parameters to specify the times for the timeframe between from & to dates.#556

Merged
uhurusurfa merged 2 commits into
OpenAS2:masterfrom
SohamBhambare:master
Jul 14, 2026
Merged

Added optional parameters to specify the times for the timeframe between from & to dates.#556
uhurusurfa merged 2 commits into
OpenAS2:masterfrom
SohamBhambare:master

Conversation

@SohamBhambare

Copy link
Copy Markdown
Contributor

Extended the /api/messages/list date-range filter (originally added to fix an OOM from unbounded queries) with optional time-of-day precision (fromTime=/toTime=), so callers can bound results to an exact date+time window instead of only whole calendar days — with validation that rejects ambiguous or contradictory inputs rather than silently guessing.

Added optional fromTime=/toTime= (HH:mm:ss) query params to /api/messages/list, layered on top of the existing from=/to= date filters, so callers can bound results to an exact date+time window instead of only whole calendar days.
test file that verifies the from/to/fromTime/toTime resolution logic in ListMessagesCommand — covering valid combinations, defaulting rules, and all the error cases (missing date for a given time, inverted ranges, malformed input).

@uhurusurfa uhurusurfa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contributions ... with unit tests 🚀

@uhurusurfa
uhurusurfa merged commit 4dd0b46 into OpenAS2:master Jul 14, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants