rpmsg buf size config via vdev config space. - #106
Conversation
tnmysh
changed the title
d975033 to
85ce487
Compare
vdev config space can be used for various rpmsg virtio configurations such as rpmsg tx and rx single buf size. Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
Current rpmsg device is not initialized with the config space. Initialze the rpmsg device with the vdev config parameters from the resource table. This configures tx and rx buffer size. Host can read this configuration and configure tx and rx buffer size accordingly. Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
Convert debug logs to info logs that prints tx and rx buffer size of the rpmsg buffer. Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
85ce487 to
433c534
Compare
| RSC_VDEV, VIRTIO_ID_RPMSG_, 31, RPMSG_VDEV_DFEATURES, 0, 0, 0, | ||
| RSC_VDEV, VIRTIO_ID_RPMSG_, 31, RPMSG_VDEV_DFEATURES, 0, | ||
| /* vdev config space len */ | ||
| sizeof(struct rpmsg_virtio_config), 0, |
There was a problem hiding this comment.
config_len here is sizeof(struct rpmsg_virtio_config) = 17 (with the current library struct), while .size in vdev_config below is set to 16, and the Linux v5 driver expects its own sizeof = 13. Three values for one length? Am I missing somehting?
There was a problem hiding this comment.
Hello @iuliana-prodan Thank you for the feedback.
This PR only reflects what was in v4. I haven't modified this PR as per v5. We are still discussing on the linux side, how this structure should look like, and once that is finalized, I will update this PR. IIRC, in v5 we decided that version should be u8, and remove all the reserved fields and make the structure __packed. That is why you see the difference. Please feel free to let me know if you have any other questions.
Thank you.
|
2026-07-15 System Reference call: |
3 participants
Corresponding Linux kernel patch series; https://lore.kernel.org/all/20251114184640.3020427-1-tanmay.shah@amd.com/
open-amp library PR: OpenAMP/open-amp#684