Upgrade test dependencies carrying known vulnerabilities - #2094
Draft
NickJosevski wants to merge 1 commit into
Draft
Upgrade test dependencies carrying known vulnerabilities#2094NickJosevski wants to merge 1 commit into
NickJosevski wants to merge 1 commit into
Conversation
NickJosevski
marked this pull request as draft
August 4, 2026 06:57
Five transitive advisories exist on main today. One is critical. .NET 10's transitive package auditing surfaced the advisories. Auditing did not create them. The net8 SDK does not audit transitives at restore. WireMock.Net goes to 2.13.0. That clears Scriban.Signed 5.5.0 with 13 advisories, System.Linq.Dynamic.Core 1.3.12 and RestSharp 110.2.0. System.DirectoryServices.AccountManagement goes to 10.0.10, clearing System.DirectoryServices.Protocols 4.7.0. RestSharp is pinned to 112.1.0 in Calamari.Testing, clearing the version reached through Octopus.1Password.Sdk. Scope is build-time exposure only. Nuke packs Calamari.Contracts and Calamari.ConsolidateCalamariPackages and nothing else. Calamari.Testing declares a PackageId but nothing packs it. No shipped artifact changes. Two advisories are deliberately left in place. SharpCompress 0.37.2 is pre-existing and already suppressed. System.Text.RegularExpressions 4.3.0 needs Octostache and Sprache to move forward. That work deserves its own change. WireMock 1.x to 2.x is a major bump. All 13 call sites were exercised behaviourally rather than just compiled. 9 tests pass. Clean rebuild at 164 warnings and 0 errors. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
NickJosevski
force-pushed
the
nj/deps-cve-test-tooling
branch
from
August 4, 2026 07:51
1b88535 to
e47255c
Compare
NickJosevski
added a commit
that referenced
this pull request
Aug 4, 2026
Serilog.Extensions.Logging 8.0.0 targets Microsoft.Extensions.Logging 8.0.0. Leaving it behind after raising Microsoft.Extensions.Logging produces a version spread across the graph. Serilog.Extensions.Logging goes to 10.0.0 in Calamari.Testing. Serilog goes to 4.4.0 in Calamari.Testing, Calamari.ConsolidateCalamariPackages and Calamari.AzureWebApp.NetCoreShim. 4.4.0 is the minimum Serilog.Extensions.Logging 10.0.0 accepts. Split out of the original combined dependency commit. The vulnerability remediations in that commit are test-only and landed separately in #2094. These Serilog bumps touch Calamari.ConsolidateCalamariPackages. That project is packed and shipped. Verified: clean rebuild of source/Calamari.sln at 165 warnings and 0 errors on net8.0. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Five transitive advisories exist on
maintoday. One is critical..NET 10's transitive package auditing surfaced the advisories. Auditing did not create them. The net8 SDK does not audit transitives at restore.
Pulled out of the .NET 10 migration branch so the work lands on its own merits.
Results
Upgrades three test-project dependencies.
Calamari.TestsCalamari.TestsCalamari.TestingOctopus.1Password.SdkScope is build-time exposure only. Nuke packs
Calamari.ContractsandCalamari.ConsolidateCalamariPackages*and nothing else.Calamari.Testingdeclares aPackageIdbut nothing packs it. No shipped artifact changes. Please do not triage as a customer-facing security fix.Two advisories are deliberately left in place. SharpCompress 0.37.2 is pre-existing and already suppressed. System.Text.RegularExpressions 4.3.0 needs Octostache and Sprache to move forward. That work deserves its own change.
Reducing risk
GitHttpSmartSubTransportTestsandAwsEnvironmentGenerationFixture.origin/mainworktree usingdotnet list package --vulnerable --include-transitive.source/Calamari.slnat 164 warnings and 0 errors.How to review this PR
General quality.