Add CODEOWNERS for maintainer approval on contributor PRs#969
Open
northdpole wants to merge 2 commits into
Open
Add CODEOWNERS for maintainer approval on contributor PRs#969northdpole wants to merge 2 commits into
northdpole wants to merge 2 commits into
Conversation
require_code_owner_reviews was enabled on main without a CODEOWNERS file, so no approval could satisfy the code-owner requirement on contributor PRs. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
WalkthroughAdded a ChangesCODEOWNERS Setup
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Pa04rth
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Branch protection on
mainhasrequire_code_owner_reviews: truebut the repo had no.github/CODEOWNERSfile. That meant no approval could satisfy the code-owner requirement on contributor PRs, forcinggh pr merge --admin.This adds default code owners so maintainer approval is sufficient to merge other people's PRs. GitHub blocks authors from self-approving as a code owner, so maintainer-authored PRs still need a second reviewer.
Changes
.github/CODEOWNERSwith default owners:@northdpole,@robvanderveer,@Pa04rth(Parth Sohaney),@paoga87(Paola Garcia).Expected behavior after merge
Test plan
--admin