Use combined rel+abs tolerance for line-segment test in test-prism#93
Merged
stevengj merged 2 commits intoJun 26, 2026
Merged
Conversation
The line-segment unit test compared a prism against an equivalent block using a pure relative tolerance. When a random segment merely grazes the shared boundary, both intersection lengths are tiny and the relative test becomes hypersensitive to the prism's internal boundary tolerance (~1e-5), producing intermittent CI failures. Add an absolute floor so boundary- ambiguous samples are absorbed while genuine divergence is still caught.
stevengj
reviewed
Jun 26, 2026
Collaborator
|
I'm still getting intermittent failures? |
Collaborator
|
(One thing we might want to do is simply to set a fixed random seed, to reduce spurious failures from unlikely cases and also to make failures more reproducible.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The line-segment unit test compared a prism against an equivalent block using a pure relative tolerance. When a random segment merely grazes the shared boundary, both intersection lengths are tiny and the relative test becomes hypersensitive to the prism's internal boundary tolerance (~1e-5), producing intermittent CI failures. Add an absolute floor so boundary- ambiguous samples are absorbed while genuine divergence is still caught.