chore: drop the executable bit from non-script files - #16
Merged
Conversation
Site assets, config and documentation were tracked as mode 100755, most likely from having originated on a filesystem that cannot represent Unix permissions. Nothing executes them - Cloudflare Pages serves static files regardless of mode - so this is tidiness rather than a behaviour change. Everything under scripts/ keeps its executable bit; each of those files has a shebang and is meant to be run directly.
Deploying easyconvert-website with
|
| Latest commit: |
d494d3d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://311689dc.easyconvert-website.pages.dev |
| Branch Preview URL: | https://chore-file-modes-644.easyconvert-website.pages.dev |
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (9)
⛔ Files ignored due to path filters (4)
⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (9)
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Site assets, config and documentation were tracked as mode
100755, most likely from having originated on a filesystem that cannot represent Unix permissions. Nothing executes them - Cloudflare Pages serves static files regardless of mode, and Content-Type comes from the file extension - so this is tidiness, not a behaviour change.13 files move
100755 -> 100644:.cfignore,.gitignore,LICENSE,dependency-review.yml, and the static assets underpublic/(_redirects,_worker.js, both SVGs,manifest.json, both logos,robots.txt,style.css).Everything under
scripts/keeps its executable bit - each of those files has a shebang and is meant to be run directly.Verification
check-action-pins.sh,check-cdn-versions.sh,check-version-sync.sh(reports 1.5.2 in sync) andrelease.shremain 755_worker.jsparses,manifest.jsonparsesFiles that PR #15 touched already picked up 644 in that commit, so this covers the remainder.