Skip to content

v1.5.1: fix missing copyright year, tidy footer legal bar, harden ignore files - #13

Merged
NX1X merged 1 commit into
mainfrom
fix/footer-legal-1.5.1
Jul 25, 2026
Merged

v1.5.1: fix missing copyright year, tidy footer legal bar, harden ignore files#13
NX1X merged 1 commit into
mainfrom
fix/footer-legal-1.5.1

Conversation

@NX1X

@NX1X NX1X commented Jul 25, 2026

Copy link
Copy Markdown
Owner

Summary

A real bug fix plus the footer polish and ignore-file hardening.

Fixed: the copyright year never rendered

initializeLanguage() only called updateLanguage() when a saved language differed from the current one:

if (savedLanguage && savedLanguage !== currentLanguage) { ... updateLanguage(); }

So a first-time visitor, or anyone whose saved language was already en, never triggered a render - the footer kept its static © NX1X placeholder and the year was missing for everyone who never toggled language. It now always renders, and an unrecognised saved language falls back to English rather than blanking the interface.

Changed: footer legal bar

The licence notice and copyright were two stacked grey lines, with the divider awkwardly between them. They are now one bar below the divider, separated by a dot, wrapping onto separate lines on narrow screens (the dot is hidden under 420px). The licence link underlines on hover instead of permanently, and has a visible keyboard focus state.

Changed: ignore files

  • .gitignore: JetBrains + *.code-workspace, Desktop.ini / $RECYCLE.BIN/, *.bak / *.orig, and key material (*.pem, *.key, *.p12, *.pfx, .dev.vars, .wrangler/)
  • .cfignore: previously had no entry for environment files or key material. Added .env*, .dev.vars, *.pem, *.key, *.p12, *.pfx, *.secret, plus .gitattributes, .editorconfig, JetBrains and workspace files. The primary control is still "build output directory = public"; this is the defence-in-depth layer.

Testing

  • Simulated the language-init path against the real index.html element ids across four cases - fresh visitor, returning en, returning he, and a junk saved language - and asserted the year renders in each (it did not before this change)
  • Confirmed no stale references to the removed .footer-license / .footer-copyright classes remain
  • node --check on app.js; check-action-pins.sh and check-cdn-versions.sh pass
  • Served locally and verified the rendered footer markup

…ores

The language initialiser only re-rendered when a saved language differed
from the current one, so visitors on the default language never got the
translated strings and the footer kept its static placeholder - the
copyright year was missing for everyone who never switched language. It
now always renders, and an unrecognised saved language falls back to
English instead of blanking the interface.

The licence notice and copyright are merged into a single bottom bar
below the divider, separated by a dot and wrapping on narrow screens.
The licence link underlines on hover rather than permanently and has a
visible focus state.

.gitignore gains JetBrains/workspace files, Windows shell artefacts,
editor backups and key material; .cfignore gains environment files and
key material so a misconfigured root-directory deploy cannot serve them.

Bump to 1.5.1.
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 25, 2026

Copy link
Copy Markdown

Deploying easyconvert-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: c9d0c15
Status: ✅  Deploy successful!
Preview URL: https://5b943eea.easyconvert-website.pages.dev
Branch Preview URL: https://fix-footer-legal-1-5-1.easyconvert-website.pages.dev

View logs

@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@NX1X, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 28 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 60fbcb75-cc38-4879-b1d5-cd2096a6f78e

📥 Commits

Reviewing files that changed from the base of the PR and between b188d87 and c9d0c15.

📒 Files selected for processing (9)
  • .cfignore
  • .gitignore
  • CHANGELOG.md
  • README.md
  • package.json
  • public/app.js
  • public/index.html
  • public/style.css
  • public/sw.js

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@NX1X
NX1X enabled auto-merge (squash) July 25, 2026 11:02
@NX1X
NX1X merged commit 5ee1063 into main Jul 25, 2026
10 checks passed
@NX1X
NX1X deleted the fix/footer-legal-1.5.1 branch July 25, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant