2091 compilation failed with fno exception#2092
Open
BartolomeyKant wants to merge 5 commits into
Open
Conversation
…eptions Replace throw with STDEXEC_THROW
ispeters
suggested changes
May 22, 2026
Contributor
ispeters
left a comment
ispeters
left a comment
There was a problem hiding this comment.
I don't actually have any authority here, but I'd prefer to see the changes made slightly narrower.
Collaborator
|
/ok to test 3f26d49 |
Contributor
Author
|
There is problems form Catch I forgot about. In local build I just remove Werror temporally. |
BartolomeyKant
force-pushed
the
2091-compilation-failed-with-fno-exception
branch
from
3f26d49 to
308401b
Compare
BartolomeyKant
commented
May 25, 2026
| #include <stdexec/__detail/__config.hpp> | ||
|
|
||
| /** | ||
| * This is a boost::throw_exception implementation provided for fno-exceptions builds |
Contributor
Author
There was a problem hiding this comment.
I'm not sure if it's a right way or not.
The problem is - there is no implementation for boost::throw_exception is case of -fno-exceptions which is used in boost::thread_pool.
Contributor
Author
Can we suppress this warning for catch2? |
ispeters
reviewed
May 25, 2026
| { | ||
| exec::function<ex::sender_tag(), | ||
| ex::completion_signatures<ex::set_value_t(), ex::set_error_t(int)>> | ||
| sndr([]() noexcept { return ex::just_error(42); }); |
Contributor
There was a problem hiding this comment.
This error doesn't require exceptions, so it could be included in a -fno-exceptions build, too.
ispeters
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solves #2091