Conversation
shivakunv
force-pushed
the
kind_demo
branch
3 times, most recently
from
6cc8709 to
56f4c3f
Compare
shivakunv
requested review from
cdesiniotis,
rahulait,
rajathagasthya and
tariq1890
Signed-off-by: Shiva Kumar (SW-CLOUD) <shivaku@nvidia.com>
| --wait \ | ||
| --timeout "${HELM_TIMEOUT}" \ | ||
| --set cdi.enabled=true \ | ||
| --set driver.enabled=false \ |
There was a problem hiding this comment.
Does this also need --toolkit.enabled=false? My understanding is nvkind cluster create already configures toolkit.
|
|
||
| log "Installing Go ${GO_VERSION}" | ||
| ensure_base_packages | ||
| curl -fsSL -o /tmp/go.tgz "https://go.dev/dl/go${GO_VERSION}.linux-amd64.tar.gz" |
There was a problem hiding this comment.
We're hardcoding to amd64. What about arm64 hosts?
| restartPolicy: Never | ||
| containers: | ||
| - name: cuda-container | ||
| image: nvcr.io/nvidia/k8s/cuda-sample:vectoradd-cuda10.2 |
There was a problem hiding this comment.
Can we use a newer vectoradd image?
|
|
||
| And install the `gpu-operator` as follows: | ||
| ```bash | ||
| helm upgrade -i --kube-context=kind-${KIND_CLUSTER_NAME} --namespace gpu-operator --create-namespace --wait nvidia-gpu-operator nvidia/gpu-operator --set cdi.enabled=true --set driver.enabled=false --set operator.runtimeClass=nvidia |
There was a problem hiding this comment.
nit: let's use multi-line here.
|
|
||
| The script will install or configure these tools if they are missing: | ||
|
|
||
| - Go `1.24.3` by default, or `NVKIND_GO_VERSION` |
There was a problem hiding this comment.
Why 1.24.3 by default? Why not newer Go?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes NVIDIA/gpu-operator#662