fix(docker): default Accept header of requests for manifest results in 404 error - #273
Open
Vertsineu wants to merge 2 commits into
Open
fix(docker): default Accept header of requests for manifest results in 404 error#273Vertsineu wants to merge 2 commits into
Vertsineu wants to merge 2 commits into
Conversation
Vertsineu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using this self-host registry, requesting for manifest with
Accept: */*will result in 404 error code.This is an open issue: issues/3938
Related code: registry/handlers/manifests.go#L94-118
To avoid such problem, I add explicit headers for all requests without explicit Accept header in
src/docker.sh