Skip to content

Fix managed memory smoke test#9654

Open
gevtushenko wants to merge 1 commit into
NVIDIA:mainfrom
gevtushenko:fix-smoke-test
Open

Fix managed memory smoke test#9654
gevtushenko wants to merge 1 commit into
NVIDIA:mainfrom
gevtushenko:fix-smoke-test

Conversation

@gevtushenko

Copy link
Copy Markdown
Collaborator

Description

CCCL tests require managed memory. For instance, all thrust tests that are added with DECLARE_VECTOR_UNITTEST check if universal vector works. Current smoke implementation didn't trigger an error if system hasn't supported managed memory.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-project-automation github-project-automation Bot moved this to Todo in CCCL Jun 30, 2026
@cccl-authenticator-app cccl-authenticator-app Bot moved this from Todo to In Review in CCCL Jun 30, 2026
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 84d0c696-e74c-4057-a9c0-3271fc9f1ee9

📥 Commits

Reviewing files that changed from the base of the PR and between 926e07e and d8a85e7.

📒 Files selected for processing (1)
  • test/cuda_smoke/cuda_runtime_smoke.cu

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Updated the managed-memory CUDA smoke test to fail when managed memory is not available, instead of skipping the check.
    • This makes unsupported environments easier to detect during validation and improves test reliability.

Walkthrough

This change modifies a CUDA smoke test for cudaMallocManaged. Previously, the test would skip execution when device managed-memory support was absent; now it uses REQUIRE to assert support unconditionally, causing the test to fail instead of skip on unsupported devices.

Changes

Smoke Test Assertion Update

Layer / File(s) Summary
Managed memory capability gate
test/cuda_smoke/cuda_runtime_smoke.cu
Replaced the SKIP(...) branch with REQUIRE(managed_supported), so the test fails rather than skips when cudaDevAttrManagedMemory is false.

important: This change causes the test to fail (rather than skip) on devices/platforms lacking managed memory support. Confirm all CI/runner targets actually support managed memory, or this will break builds on unsupported hardware.


Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

1 participant