Skip to content

Pacify clang-tidy for ncclCommInitAll()#9651

Merged
Jacobfaib merged 1 commit into
NVIDIA:mainfrom
Jacobfaib:jacobf/2026-06-30/fix-narrowing-nccl
Jun 30, 2026
Merged

Pacify clang-tidy for ncclCommInitAll()#9651
Jacobfaib merged 1 commit into
NVIDIA:mainfrom
Jacobfaib:jacobf/2026-06-30/fix-narrowing-nccl

Conversation

@Jacobfaib

Copy link
Copy Markdown
Contributor

Description

closes

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Jacobfaib Jacobfaib self-assigned this Jun 30, 2026
@Jacobfaib Jacobfaib requested a review from a team as a code owner June 30, 2026 19:00
@Jacobfaib Jacobfaib requested a review from caugonnet June 30, 2026 19:00
@github-project-automation github-project-automation Bot moved this to Todo in CCCL Jun 30, 2026
@cccl-authenticator-app cccl-authenticator-app Bot moved this from Todo to In Review in CCCL Jun 30, 2026
@Jacobfaib Jacobfaib enabled auto-merge (squash) June 30, 2026 19:03
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ec66ddf6-1b93-4733-8ca0-a264327fd482

📥 Commits

Reviewing files that changed from the base of the PR and between 3d5f235 and bfb06fd.

📒 Files selected for processing (1)
  • cudax/test/multi_gpu/communicators/nccl/nccl_test_helpers.cuh

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated an internal multi-GPU test helper to use an explicit device-count conversion, improving type safety with no change in behavior.

Walkthrough

This PR modifies a single line in the nccl_comm_fixture constructor, changing the device count argument passed to ncclCommInitAll from an implicit size_t-to-int conversion to an explicit static_cast. No behavioral or control flow changes occur elsewhere.

Changes

NCCL Test Fixture Fix

Layer / File(s) Summary
Explicit cast for device count
cudax/test/multi_gpu/communicators/nccl/nccl_test_helpers.cuh
ncclCommInitAll call updated to use static_cast<int>(devs.size()) instead of implicit conversion.

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

🥳 CI Workflow Results

🟩 Finished in 3h 50m: Pass: 100%/53 | Total: 5h 31m | Max: 1h 05m | Hits: 96%/36164

See results here.

@Jacobfaib Jacobfaib merged commit 8ae5067 into NVIDIA:main Jun 30, 2026
75 of 76 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in CCCL Jun 30, 2026
@Jacobfaib Jacobfaib deleted the jacobf/2026-06-30/fix-narrowing-nccl branch July 1, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants