chore(helm): add missing SPDX header to gateway-config template#1545
Open
mesutoezdil wants to merge 2 commits into
Open
chore(helm): add missing SPDX header to gateway-config template#1545mesutoezdil wants to merge 2 commits into
mesutoezdil wants to merge 2 commits into
Conversation
mesutoezdil
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
Collaborator
|
This directory is explicitly bypassed in .@TaylorMutch any ideas why? We shouldn't be doing one off PRs to add headers, this is why we have a script for it. So we should either include this directory or not worry about it. |
Collaborator
I don't have any memory adding the ignore there. I think we can remove the exclusion and have the headers added uniformly. |
The bypass had no known rationale. Removing it ensures the header script covers deploy/helm/openshell/templates uniformly going forward. Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
Contributor
Author
|
i v removed the exclusion from scripts/update_license_headers.py so the helm templates dir is covered uniformly going forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the missing SPDX copyright and license header to
deploy/helm/openshell/templates/gateway-config.yamlEvery other file in
deploy/helm/openshell/templates/already has this header. This was the only file missing it.