fix(scripts): replace mapfile with bash 3.2-compatible read loop in helm-k3s-local#1539
Open
mesutoezdil wants to merge 1 commit into
Open
fix(scripts): replace mapfile with bash 3.2-compatible read loop in helm-k3s-local#1539mesutoezdil wants to merge 1 commit into
mesutoezdil wants to merge 1 commit into
Conversation
…elm-k3s-local macOS ships bash 3.2 which lacks mapfile/readarray. Replace all three occurrences in configure_ghcr_credentials, cluster_has_image, and cluster_image_platform with a portable while-read loop, consistent with the fix applied to docker-build-image.sh in NVIDIA#1334.
mesutoezdil
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mapfileis bash 4+ only. macOS ships bash 3.2, sohelm-k3s-local.shfails on the primary target platform. Replaces all three occurrences with a portablewhile readloop, the same fix applied todocker-build-image.shin #1334.tasks/scripts/helm-k3s-local.sh: replacemapfile -t nodeswithwhile IFS= read -r _nodeinconfigure_ghcr_credentials,cluster_has_image, andcluster_image_platformTesting -
bash -n tasks/scripts/helm-k3s-local.shpasses on bash 3.2 and bash 5