fix: scale divides by first value without zero guard - #98
Open
andrewwhitecdw wants to merge 4 commits into
Open
Conversation
andrewwhitecdw
marked this pull request as ready for review
July 28, 2026 00:37
added 3 commits
July 31, 2026 20:19
Auditor: The guard returns 0.0 for a zero baseline, but this function computes a relative scale ratio (slope/first value + 1), so the undefined zero-baseline case should be NaN/raise, not a misleading finite scale. This silently changes semantics and lacks a regression test.
Auditor: Proposed diff adds a zero guard but returns float('nan'), which contradicts the stated fix (return 0.0) and could propagate NaN downstream instead of a finite sentinel.
Auditor: Returning 0.0 when values[0] == 0 is an arbitrary sentinel that masks an undefined relative scale and can silently corrupt downstream calculations; the guard is also placed after an unnecessary polyfit, and no regression test verifies the behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
fix: scale divides by first value without zero guard
Fix
Replace:
with:
Files changed
bobber/lib/analysis/table.py