fix: save_config annotated as NoReturn but returns None

[andrewwhitecdw]

This PR addresses the following issue in bobber/bobber.py: save_config annotated as NoReturn but returns None.

Changes

• bobber/bobber.py: save_config annotated as NoReturn but returns None.

Details

--- a/bobber/bobber.py
+++ b/bobber/bobber.py
@@ -1,1 +1,1 @@
-def save_config(args: Namespace) -> NoReturn:
+def save_config(args: Namespace) -> None:

Tests

• tests/test_bobber_annotations.py

--- /dev/null
+++ b/tests/test_bobber_annotations.py
@@ -0,0 +1,15 @@
+import ast
+import unittest
+
+
+class TestReturnAnnotations(unittest.TestCase):
+    def _get_return_annotation(self, func_name):
+        with open('bobber/bobber.py') as f:
+            tree = ast.parse(f.read())
+        for node in ast.walk(tree):
+            if isinstance(node, ast.FunctionDef) and node.name == func_name:
+                return node.returns
+        self.fail(f'{func_name} not found')
+
+    def test_save_config_returns_none(self):
+        self.assertEqual(ast.unparse(self._get_return_annotation('save_config')), 'None')

Contributor guidelines

Per this repo's CONTRIBUTING.md:

• All commits are signed off (Signed-off-by trailer, DCO).