Increasing test coverage#1289
Draft
ORybak5 wants to merge 1 commit into
Draft
Conversation
|
Looks good. No mutations were possible for these changes. |
|
Images built and published to ECR using a Build Id of PR-1147-7b3a583 |
There was a problem hiding this comment.
Pull request overview
This PR increases unit test coverage in the common module by adding new JUnit 5 tests for core utility/services, improving confidence in JSON/FHIR parsing and logging-context handling.
Changes:
- Add
FhirParserTestcovering parsing valid/invalid JSON into FHIRParametersand encoding resources to JSON. - Add
MDCServiceTestcovering setting/getting and resetting the conversation ID stored in SLF4J MDC.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| common/src/test/java/uk/nhs/adaptors/common/util/fhir/FhirParserTest.java | Adds unit tests for FHIR JSON parse/encode behavior and invalid JSON handling. |
| common/src/test/java/uk/nhs/adaptors/common/service/MDCServiceTest.java | Adds unit tests for applying and clearing the MDC conversation ID. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+40
to
+43
| var encoded = fhirParser.encodeToJson(parameters); | ||
|
|
||
| assertTrue(encoded.contains("\"resourceType\": \"Parameters\"")); | ||
| assertTrue(encoded.contains("\"name\": \"test-name\"")); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Increasing the adaptor's test coverage
Why
The more tests that cover different scenarios, the better, as they increase confidence in the adaptor and help maintain quality
Type of change
Please delete options that are not relevant.
Checklist: