feat: Add semble install by Pringled · Pull Request #176 · MinishLab/semble

Pringled · 2026-06-02T17:31:16Z

This PR adds a semble install command. It detects installed coding agents and configures semble globally across three integration types (MCP, instructions, sub-agent). We use tree-sitter for json/jsonc parsing so comments in MCP/settings jsons are preserved.

Here's what the flow looks like in the terminal on runningsemble install (semble uninstall gives the same flow but the reverse (uninstalling whatever is selected)):

codecov · 2026-06-02T17:32:05Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines	Coverage Δ
src/semble/cli.py	`100.00% <100.00%> (ø)`
src/semble/installer.py	`100.00% <100.00%> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Pringled · 2026-06-02T17:32:17Z

@greptileai review

greptile-apps · 2026-06-02T17:40:52Z

Confidence Score: 4/5

Safe to merge with one follow-up: the uninstall code path needs an end-to-end test.

The installer logic itself is sound and individual helpers are well-tested. The gap is that run("uninstall") is never called end-to-end — the full uninstall flow (remove operations, "not-found" returns through _apply, different UI text, different footer) can silently regress without the test suite catching it. The reviewer specifically asked for e2e coverage of all codepaths, so this missing test is the main concern.

tests/test_installer.py — needs a run("uninstall") end-to-end test to match the run("install") test that already exists.

_{Reviews (3): Last reviewed commit: "Fix toml edgecase" | Re-trigger Greptile}

greptile-apps · 2026-06-02T17:41:36Z

Confidence Score: 3/5

The install path works correctly for fresh configs; the uninstall path can corrupt pre-existing configs where semble was not the first entry.

The _delete_member function only removes an adjacent comma correctly when semble was inserted as the first member. If semble was added last by another tool (e.g. claude mcp add) and the user then runs semble uninstall, the preceding entry's trailing comma is left in place, making strict-JSON files like .claude.json invalid. The JSON5-based validation guard does not catch it.

src/semble/installer.py — specifically the _delete_member function and the missing test case in tests/test_installer.py.

_{Reviews (2): Last reviewed commit: "Group types/vars" | Re-trigger Greptile}

Pringled · 2026-06-03T05:33:00Z

@greptileai review this branch again main. Focus on two things:

e2e testing, ensuring that all the codepaths and combinations resolve correctly or have a clear error message when they fail
architecture, ensuring that the architecture for the installer is maintainable, easy to understand, and not over-engineered

stephantul

Small docs comments, but looks good!

stephantul · 2026-06-03T06:59:04Z

+```bash
+uv tool install semble
+semble install           # configure your agents
+semble uninstall         # undo


This is a bit weird, because the instruction seems to imply that you need to uninstall it immediately. Maybe make it a separate block?

i.e., if I copy paste this block, I'll just install and uninstall.

stephantul · 2026-06-03T07:01:07Z

    """Return the project-relative path where the semble sub-agent file should be written."""
    base_dir = ".github" if agent is Agent.COPILOT else f".{agent.value}"
-    return Path(base_dir) / "agents" / "semble-search.md"
+    # Copilot requires the .agent.md extension; the others use a plain .md file.


do the others not accept .agent.md? As in: copilot only reads .agent.md files, but maybe the others do as well. If so, could be useful to just keep it like this. But maybe a bit brittle

stephantul · 2026-06-03T07:01:49Z

    "tree-sitter-language-pack>=1.0,<1.8.0,!=1.6.3",
-    "orjson"
+    "orjson",
+    "questionary>=2.0",


maybe an upper bound on the pin as well? (i.e., <3.0)

stephantul · 2026-06-03T07:03:54Z

+from tree_sitter import Node, Parser
+from tree_sitter_language_pack import SupportedLanguage, download, get_parser
+
+_HOME = Path.home()


Just out of caution: if this function does not work for some reason, this script will fail on import. I'm not sure if it ever will, just something to keep in mind.

To avoid this, you can create a function and potentially cache the result.

stephantul · 2026-06-03T07:08:02Z

+    "json5" ships in tree-sitter-language-pack but isn't in its typed language list, hence the cast.
+    """
+    try:
+        download(["json5"])


we can potentially ship this grammar with the package. It's a useful exception. I don't know how large it is, but I suspect it's pretty small.

stephantul · 2026-06-03T07:08:41Z

+]
+
+
+def _json5_parser() -> Parser | None:


I think this could be cached: if the download fails or times out, it will fail or time out every time.

stephantul · 2026-06-03T07:10:25Z

+        return None
+
+
+def _json5_object(text: str) -> JsonObjectResult:


I'm not a big fan of these kinds of returns: they put a lot of work in the caller. Instead, you could consider returning a tuple containing

(result, success)

if success is True, you can safely read result, if it is False, the result contains the reason for the error.

stephantul · 2026-06-03T07:17:02Z

+class McpConfig:
+    """MCP integration config for one agent."""
+
+    path: Path | PathResolver


As far as I can tell, there is no need for this disjunction. The paths can resolve when creating the McpConfig itself, e.g.

instead of doing:

McpConfig(_vscode_mcp_path)

you can do:

McpConfig(_vscode_mcp_path())

stephantul · 2026-06-03T07:18:21Z

+SEMBLE_START = "<!-- SEMBLE_START -->"
+SEMBLE_END = "<!-- SEMBLE_END -->"
+
+_STDIO_ENTRY: dict[str, object] = {


I think the use of _ENTRY is slightly ambiguous here. I first read it as "an entry" (i.e., a record), but I think you mean "entrypoint"? If so, maybe rename it to read entrypoint.

stephantul · 2026-06-03T07:20:27Z

One thing I think would really improve this code is moving the JSON5 and TOML parsing to a separate file or separate files. It would lead to a lot more readability. Likewise, the definitions can move to a separate const file? That way you separate the entry points for the TOML and JSON5 parsing from the rest of the code, and also separate the constants from operational code. I think just making a submodule called installer and adding those under this could be fine.

Pringled added 12 commits June 1, 2026 09:16

Add semble install

59c4c26

Add semble install

459e782

Add semble install

c36799d

Use tree sitter for json5 parsing

7c1dca7

Make json5 download explicit

0c809f4

Simplify

0e5155c

Add McpConfig

55a101d

Add informative error message

732e1b0

Add merge/remove mcp helpers

8fdc99d

Reorder

1a47d47

Reorder

2963053

Group types/vars

db1ac05

greptile-apps Bot reviewed Jun 2, 2026

View reviewed changes

Comment thread src/semble/installer.py

Comment thread src/semble/installer.py

greptile-apps Bot reviewed Jun 2, 2026

View reviewed changes

Comment thread src/semble/installer.py

Comment thread src/semble/installer.py

Comment thread src/semble/installer.py

Pringled added 4 commits June 3, 2026 06:41

Resolve comments

68bb797

Improve test coverage

c627d20

Resolve comments

880f4d9

Fix toml edgecase

c443fb6

Pringled added 2 commits June 3, 2026 07:41

Align instructions

99b9462

Fix bug with sub tables in codex

e4dceff

Pringled requested a review from stephantul June 3, 2026 05:58

Pringled added 4 commits June 3, 2026 08:32

Update docs

3f184e1

Add separate install doc

68040b1

Add separate install doc

e2b0148

Update docs

a0c416f

Update docs

490b91a

stephantul approved these changes Jun 3, 2026

View reviewed changes

		return None


		def _json5_object(text: str) -> JsonObjectResult:

Conversation

Pringled commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Pringled commented Jun 2, 2026

Uh oh!

greptile-apps Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 4/5

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot commented Jun 2, 2026

Confidence Score: 3/5

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pringled commented Jun 3, 2026

Uh oh!

stephantul left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Pringled commented Jun 2, 2026 •

edited

Loading

codecov Bot commented Jun 2, 2026 •

edited

Loading

greptile-apps Bot commented Jun 2, 2026 •

edited

Loading