Skip to content

AHRS Device Orientation Computation#240

Open
JSMTHWCK wants to merge 3 commits into
developmentfrom
feature/ES-880_AHRS
Open

AHRS Device Orientation Computation#240
JSMTHWCK wants to merge 3 commits into
developmentfrom
feature/ES-880_AHRS

Conversation

@JSMTHWCK
Copy link
Copy Markdown

@JSMTHWCK JSMTHWCK commented Apr 3, 2026

Created a method endaq.ide.compute_orientation(doc) that computes the Orientation of a device with results comparable to that of the imu. Helper methods copied from PR#238, with test methods and test files for the created method.

…iles. Updated requirements / setup to accommodate needed package
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 3, 2026

Codecov Report

❌ Patch coverage is 95.31250% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.86%. Comparing base (25bf365) to head (1fdea79).

Files with missing lines Patch % Lines
endaq/calc/utils.py 93.61% 3 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #240      +/-   ##
===============================================
+ Coverage        71.36%   71.86%   +0.49%     
===============================================
  Files               35       35              
  Lines             3279     3337      +58     
===============================================
+ Hits              2340     2398      +58     
  Misses             939      939              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JSMTHWCK JSMTHWCK marked this pull request as ready for review April 8, 2026 12:35
@JSMTHWCK JSMTHWCK requested review from StokesMIDE and pscheidler June 1, 2026 17:37
Copy link
Copy Markdown
Member

@pscheidler pscheidler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good work, I tested it out a few ways and the results look great.
I think compute_orientation should go into endaq.calc instead of endaq.ide, I don't remember if we talked about this before, but if @StokesMIDE is fine with it then I'm fine with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants