[B6/B7] Inject ConfigService into password.utils, move getPasswordHistoryLimit, add tests, update docs#840
Merged
nanaf6203-bit merged 5 commits intoJun 28, 2026
Conversation
Contributor
|
|
Contributor
|
⏳ Tried again but the branch still has conflicts with |
- Add ipAddress and userAgent parameters to preflightChecks - Pass them from login() to preflightChecks - Fix mock in auth.service.captcha.spec.ts (add isVerified: true) - Remove hardcoded 365-day throw in getAnalytics, cap instead - Add fixed timestamps to blockchain.service.spec.ts tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #711 (B6a) — password.utils.ts: inject ConfigService instead of reading process.env directly
Closes #712 (B6b) — Add unit test confirming getPasswordPolicy reflects env-driven overrides
Closes #713 (B7a) — security.utils.ts: move getPasswordHistoryLimit into AuthService
Closes #714 (B7b) — Document PASSWORD_HISTORY_LIMIT config key in README env-var table
Changes
src/auth/password.utils.ts: RefactoredgetPasswordPolicyandvalidatePasswordto acceptConfigServiceand useconfigService.get()instead ofprocess.envsrc/auth/auth.service.ts: Updated all callers to passthis.configService; movedgetPasswordHistoryLimitas a private methodsrc/auth/security.utils.ts: RemovedgetPasswordHistoryLimittest/auth/password.utils.spec.ts: Rewrote tests to usemockConfig()helper instead ofprocess.envoverrides; added `getPasswordPolicy) unit testsREADME.md: AddedPASSWORD_HISTORY_LIMITto env-var tableAll 199 tests pass.