feat(tui): Complete TUI implementation#14
Draft
Masterisk-F wants to merge 2 commits into
Draft
Conversation
This commit includes the following fixes for the TUI: - Remove duplicate tUIDisc.rb file - Fix typo in update queue event name for multiple records - Dynamically calculate layout height in Preferences to avoid overflow - Use synchronous system calls for log/dir opening in Summary
…and 159 tests ## Changes - **Gemfile**: Added dependency definition for tty-prompt, tty-table, tty-box, tty-reader, tty-spinner, pastel, rspec - **bin/rubyripper_tui**: New TUI entrypoint script (installable via configure --enable-tui as rrr_tui) - **Preferences::Data**: Added attr_accessor :uiType - **Preferences::SetDefaults**: Default uiType to 'tui' - **configure**: Added --enable-tui support with install/uninstall of rrr_tui ## Tests (159 examples, 0 failures, 1 pending) - spec/tui/tui_helpers_spec.rb — 17 tests for color/clear/header/footer - spec/tui/tui_key_handler_spec.rb — 23 tests for all key mappings - spec/tui/tui_messages_spec.rb — 28 tests for all state transitions + draw - spec/tui/tui_disc_spec.rb — 22 tests for scan/save/edit/select/draw - spec/tui/tui_preferences_spec.rb — 21 tests for tabs/focus/edit/save/uiType - spec/tui/tui_rip_status_spec.rb — 16 tests for progress/logs/cancel/dir - spec/tui/tui_multiple_hits_spec.rb — 2 tests for Gnudb/MusicBrainz - spec/tui/tui_summary_spec.rb — 8 tests for success/fail/actions - spec/tui/tui_app_spec.rb — 22 tests for init/queue/keys/errors - spec/preferences/data_spec.rb — 3 tests for uiType accessor + default ## Pending - TUIDisc draw: musicbrainz_failed stub does not override parent context (RSpec @instance_variable double interaction issue)
Owner
Author
実装内容この PR は 実装したコード修正(5 ファイル)
追加したテスト(10 ファイル、159 ケース)
実行結果: 未解決の課題1.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Complete the TUI (Terminal User Interface) implementation with all core components.
Changes
Key Fixes