Skip to content

feat: toggle submissions table#8047

Open
YheChen wants to merge 5 commits into
MarkUsProject:masterfrom
YheChen:feat/toggle-submissions-table
Open

feat: toggle submissions table#8047
YheChen wants to merge 5 commits into
MarkUsProject:masterfrom
YheChen:feat/toggle-submissions-table

Conversation

@YheChen

@YheChen YheChen commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)

Ref #6424

This PR allows graders with the manage submissions permission to toggle the submissions table between:

  • all submissions for the assignment
  • only submissions assigned to them

This mirrors the existing inactive-groups toggle pattern in the submissions table. The backend now includes an assigned flag in submission table data for managed graders, while graders without manage-submissions permission continue to only receive their assigned submissions. The submissions table uses that flag for a hidden filter column and exposes a new “Display assigned submissions only” checkbox only when applicable.

Tests were added for both the React table filtering behavior and the assignment submission-data contract.

Screenshots of your changes (if applicable) image

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality) x
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots) x
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
📖 Documentation update (change that updates documentation)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls

coveralls commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 28990180113

Coverage increased (+0.005%) to 90.291%

Details

  • Coverage increased (+0.005%) from the base build.
  • Patch coverage: 33 of 33 lines across 3 files are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 51052
Covered Lines: 47108
Line Coverage: 92.27%
Relevant Branches: 2454
Covered Branches: 1203
Branch Coverage: 49.02%
Branches in Coverage %: Yes
Coverage Strength: 127.37 hits per line

💛 - Coveralls

@YheChen YheChen requested a review from david-yz-liu July 7, 2026 03:33
@YheChen YheChen changed the title WIP: feat: toggle submissions table feat: toggle submissions table Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants