Fix: Fixed Assignment page dropdown menu not redirecting to selected assignment#8043
Merged
david-yz-liu merged 5 commits intoJul 7, 2026
Merged
Conversation
Collaborator
Coverage Report for CI Build 28886663895Coverage remained the same at 90.286%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
david-yz-liu
reviewed
Jul 6, 2026
| session[:job_id] = @current_job.job_id | ||
| end | ||
| redirect_back(fallback_location: root_path) | ||
| redirect_back_or_to(root_path) |
Collaborator
There was a problem hiding this comment.
Yeah please revert these changes. I'm not sure why they are being flagged by rubocop on your machine, but in any case you should revert them here, but in a separate PR you can run rubocop on all files (pre-commit run --all-files rubocop). This should address the issue for all source files, not just this one.
… bug/fix-assignment-dropdown
david-yz-liu
approved these changes
Jul 7, 2026
david-yz-liu
left a comment
Collaborator
There was a problem hiding this comment.
Nice work, @mrafie1!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)
Resolves #8023
Issue:
On the Assignment index page, pressing on any assignment in the dropdown menu will not redirect the user to the default action of that assignment.
Fix:
app/controllers/assignments_controller.rbswitch_to_samefunction to return False when the user is on the Assignment index page, as they should not be redirected to the 'same' page and should be redirected to their default page for the assignment.default_path_for_rolefunction to return default action/path for userswitchfunction to usedefault_path_for_roleMisc:
redirect_backorredirect_back_or_towere made by RuboCop.Screenshots of your changes (if applicable)
Instructor View:
Screen.Recording.2026-07-06.at.12.36.12.mov
Grader/TA View:
Screen.Recording.2026-07-06.at.12.36.55.mov
Student View:
Screen.Recording.2026-07-06.at.12.37.40.mov
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)
Should I revert the changes made by RuboCop? I'm not exactly sure why they were edited.