Skip to content

Fix: Fixed Assignment page dropdown menu not redirecting to selected assignment#8043

Merged
david-yz-liu merged 5 commits into
MarkUsProject:masterfrom
mrafie1:bug/fix-assignment-dropdown
Jul 7, 2026
Merged

Fix: Fixed Assignment page dropdown menu not redirecting to selected assignment#8043
david-yz-liu merged 5 commits into
MarkUsProject:masterfrom
mrafie1:bug/fix-assignment-dropdown

Conversation

@mrafie1

@mrafie1 mrafie1 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)

Resolves #8023

Issue:

On the Assignment index page, pressing on any assignment in the dropdown menu will not redirect the user to the default action of that assignment.

Fix:

app/controllers/assignments_controller.rb

  • Edited switch_to_same function to return False when the user is on the Assignment index page, as they should not be redirected to the 'same' page and should be redirected to their default page for the assignment.
  • Added default_path_for_role function to return default action/path for user
  • Refactored switch function to use default_path_for_role

Misc:

  • Any changes to redirect_back or redirect_back_or_to were made by RuboCop.
Screenshots of your changes (if applicable)

Instructor View:

Screen.Recording.2026-07-06.at.12.36.12.mov

Grader/TA View:

Screen.Recording.2026-07-06.at.12.36.55.mov

Student View:

Screen.Recording.2026-07-06.at.12.37.40.mov

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue) x
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
📖 Documentation update (change that updates documentation)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

Should I revert the changes made by RuboCop? I'm not exactly sure why they were edited.

@mrafie1 mrafie1 marked this pull request as draft July 6, 2026 00:46
@coveralls

coveralls commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 28886663895

Coverage remained the same at 90.286%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: 7 of 7 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 51026
Covered Lines: 47082
Line Coverage: 92.27%
Relevant Branches: 2444
Covered Branches: 1194
Branch Coverage: 48.85%
Branches in Coverage %: Yes
Coverage Strength: 127.13 hits per line

💛 - Coveralls

@mrafie1 mrafie1 changed the title Fix: Fixed Assignment page dropdown menu not redirecting to assignments Fix: Fixed Assignment page dropdown menu not redirecting to selected assignment Jul 6, 2026
@mrafie1 mrafie1 marked this pull request as ready for review July 6, 2026 16:47
@mrafie1 mrafie1 requested a review from david-yz-liu July 6, 2026 17:06
Comment thread app/controllers/assignments_controller.rb Outdated
session[:job_id] = @current_job.job_id
end
redirect_back(fallback_location: root_path)
redirect_back_or_to(root_path)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah please revert these changes. I'm not sure why they are being flagged by rubocop on your machine, but in any case you should revert them here, but in a separate PR you can run rubocop on all files (pre-commit run --all-files rubocop). This should address the issue for all source files, not just this one.

@mrafie1 mrafie1 requested a review from david-yz-liu July 7, 2026 18:27

@david-yz-liu david-yz-liu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @mrafie1!

@david-yz-liu david-yz-liu merged commit 7afdac6 into MarkUsProject:master Jul 7, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assignment selection dropdown fails to open selected assignment

3 participants