chore: remove dead storage-challenge and health-check Hash helpers#300
Open
j-rafique wants to merge 1 commit into
Open
chore: remove dead storage-challenge and health-check Hash helpers#300j-rafique wants to merge 1 commit into
j-rafique wants to merge 1 commit into
Conversation
Drops 7 unreachable functions flagged by `deadcode -test ./...`:
pkg/types/storage_challenge.go
- MessageTypeFromString
- (StorageChallengeMessages).Hash + the orphan slice type
- (AggregatedScoreList).Hash + the orphan slice type
pkg/types/healthcheck_challenge.go
- (HealthCheckChallengeMessages).Hash + the orphan slice type
pkg/utils/storagechallenge/storage_challenge.go (whole pkg, orphan)
pkg/utils/healthcheckchallenge/health_check_challenge.go (whole pkg, orphan)
pkg/storagechallenge/deterministic/deterministic.go
- EpochStartHeight
Verified via deadcode diff on origin/master @ 82cebf7: baseline 147 ->
after 140 (exactly the 7 above removed, no new findings). MessageType,
HealthCheckMessage and the consumed deterministic helpers stay.
go build ./..., go vet ./..., and go test ./... -short -count=1 pass
in the supernode module; sn-manager, cmd/sncli, and tests/system also
build clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops 7 unreachable functions flagged by
deadcode -test ./...:pkg/types/storage_challenge.go
- MessageTypeFromString
- (StorageChallengeMessages).Hash + the orphan slice type
- (AggregatedScoreList).Hash + the orphan slice type pkg/types/healthcheck_challenge.go
- (HealthCheckChallengeMessages).Hash + the orphan slice type
pkg/utils/storagechallenge/storage_challenge.go (whole pkg, orphan)
pkg/utils/healthcheckchallenge/health_check_challenge.go (whole pkg, orphan)
pkg/storagechallenge/deterministic/deterministic.go
- EpochStartHeight
Verified via deadcode diff on origin/master @ 82cebf7: baseline 147 ->
after 140 (exactly the 7 above removed, no new findings). MessageType, HealthCheckMessage and the consumed deterministic helpers stay.
go build ./..., go vet ./..., and go test ./... -short -count=1 pass in the supernode module; sn-manager, cmd/sncli, and tests/system also build clean.