fix(search): fall back to keyword search when author doesn't resolve to an Audible author page#750
Draft
kevinheneveld wants to merge 2 commits into
Draft
Conversation
…resolve to an Audible author page AUTHOR_TITLE search required the author name to match an Audible author page via AudibleAuthorPageCollector; when it didn't (a whisper-transcribed author name with STT spelling errors, e.g. "Whisher" for the real "Wisher"), the whole search returned nothing with no other recourse — even though the book was genuinely on Audible under the correctly-spelled author. Confirmed live: "The Hidden Tower" by James E. Wisher (misheard as "Whisher") failed in all 4 regions with "No author ASIN found for author" logged each time. AudibleService.SearchByTitleAndAuthorPagedAsync already implements exactly this fallback (a plain keyword title+author search that doesn't require an author-page match) for its own single-page callers, but it was never wired into the AUTHOR_TITLE branch used by the "find correct match" / advanced search flow. Call it when the author-page lookup comes back empty.
…to zero results Audible's "author" query parameter is a filter, not a fuzzy hint: combined with title, it can zero out results the title alone would find, when the author string doesn't read as close enough to a real catalog author. Confirmed live: "the hidden tower" + author "James E. Whisher" (the real "Wisher", misheard) returned 0 combined results from Audible directly, while title alone returned 5, including the correct book. Add one more fallback tier in AudibleAuthorSearchWorkflow: when the title+author keyword search (added in the previous commit) also comes back empty, retry title-only. This is the manual "find correct match" review flow, so the user still picks the right candidate from the list rather than anything being auto-applied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AUTHOR_TITLEsearch required the author name to match an Audible author page viaAudibleAuthorPageCollector; when it didn't (e.g. a whisper-transcribed author name with STT spelling errors — "Whisher" for the real "Wisher"), the whole search returned nothing with no other recourse, even though the book was genuinely on AudibleAudibleService.SearchByTitleAndAuthorPagedAsyncalready implements exactly this fallback (a plain keyword title+author search that doesn't require an author-page match) for its own single-page callers, but it was never wired into theAUTHOR_TITLEbranch used by the "find correct match" / advanced search flowTest plan
dotnet build— cleandotnet test— 1189/1189 passingDraft per PR-pacing convention (several PRs already active); will promote when a slot frees up.