fix(library): sort audiobook files by natural filename order#746
Draft
kevinheneveld wants to merge 1 commit into
Draft
fix(library): sort audiobook files by natural filename order#746kevinheneveld wants to merge 1 commit into
kevinheneveld wants to merge 1 commit into
Conversation
EF returns audiobook files in undefined (row-insertion/scan) order, so
multi-part books rendered jumbled on the detail page ("Part 116, 100,
049, 065, 095, 016..." instead of ascending order).
Add a shared NaturalSort key builder (treats embedded digit runs as
numeric so "Part 2" sorts before "Part 10") and an
AudiobookFileOrdering.InNaturalOrder helper, then apply it to the two
API projections that feed the frontend file list: the audiobook
detail-page endpoint and the DTO builder used by scan/move broadcasts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NaturalSortkey builder (treats embedded digit runs as numeric so "Part 2" sorts before "Part 10") and anAudiobookFileOrdering.InNaturalOrderhelperLibraryQueryWorkflow.MapDetails) and the DTO builder used by scan/move broadcasts (AudiobookDtoFactory.BuildFromEntity)Test plan
dotnet build— clean, 0 warningsdotnet test— 1189/1189 passingDraft per PR-pacing convention (several PRs already active); will promote when a slot frees up.