[PLT-2655] Update UserGroup for V3 APIs#1986
Merged
Merged
Conversation
lb-pno
marked this pull request as ready for review
June 12, 2025 19:58
lb-pno
marked this pull request as draft
June 12, 2025 20:47
lb-pno
force-pushed
the
pno/PLT-2655-fix-user-group
branch
from
June 12, 2025 21:34
b04eb53 to
d2ebd76
Compare
lb-pno
marked this pull request as ready for review
June 13, 2025 00:38
midhun-pm
reviewed
Jun 13, 2025
midhun-pm
reviewed
Jun 13, 2025
midhun-pm
reviewed
Jun 13, 2025
midhun-pm
reviewed
Jun 13, 2025
midhun-pm
reviewed
Jun 13, 2025
midhun-pm
reviewed
Jun 13, 2025
Comment on lines
+124
to
+125
| users: Legacy set of users (maintained for backward compatibility). | ||
| members: Set of UserGroupMember objects with explicit roles. |
Contributor
There was a problem hiding this comment.
Should we also ensure that either users or members is used but not both?
midhun-pm
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PLT-2655
To resolve the problems with group memberships encountered when using
UserGroup, methods have been updated to utilise V3 APIs.Changes
Create
Legacy mode
New attribute: members
Note:
memberstakes precedence overusersif used simultaneously.Update
Delete
Fixes # PLT-2655
Type of change
Please delete options that are not relevant.
All Submissions
New Feature Submissions
Changes to Core Features