Skip to content

GitHub Issue 1188: Stop JDBC caching by default in QueryService #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
labkey-jeckels wants to merge 2 commits into
base: develop
Choose a base branch
from
+4 −4
Open

GitHub Issue 1188: Stop JDBC caching by default in QueryService #1221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c63edc
GitHub Issue 1188: Stop JDBC caching by default in QueryService
labkey-jeckels May 24, 2026
8274a13
Merge remote-tracking branch 'origin/develop' into fb_selectCache
labkey-jeckels May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/org/labkey/targetedms/TargetedMSManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1272,7 +1272,7 @@ public List<InstrumentNickname> getNickname(String name, TargetedMSSchema schema
"FROM targetedms.SampleFile WHERE InstrumentNickname = " +
new StandardDialectStringHandler().quoteStringLiteral(name) +
" ORDER By InstrumentNickname, InstrumentId.Model, InstrumentSerialNumber";
TableSelector selector = QueryService.get().selector(schema, sql);
SqlSelector selector = QueryService.get().getSelectBuilder(schema, sql).buildSqlSelector();
result = selector.getArrayList(InstrumentNickname.class);
Container targetContainer;
if (shared.hasPermission(schema.getUser(), UpdatePermission.class))
Expand Down
6 changes: 3 additions & 3 deletions src/org/labkey/targetedms/folderImport/PanoramaQCSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ public void exportSettings(VirtualFile vf, Container container, User user) throw
.append(TargetedMSManager.getTableInfoQCMetricConfiguration(), "qcMetricConfig")
.append(" ON qcEnabledMetrics.metric = qcMetricConfig.Id");

try (Results results = QueryService.get().selectResults(schema, sql.getSQL(), null, null, true, true))
try (Results results = QueryService.get().getSelectBuilder(schema, sql.getSQL(), true).select())
{
exportSettingsToTSV(vf, results, getSettingsFileName(), getTableName());
}
Expand Down Expand Up @@ -146,7 +146,7 @@ public void exportSettings(VirtualFile vf, Container container, User user) throw
.append(" ) qcAnnotationType")
.append(" ON qcAnnotation.QCAnnotationTypeId = qcAnnotationType.Id");

try (Results results = QueryService.get().selectResults(schema, sql.getSQL(), null, null, true, true))
try (Results results = QueryService.get().getSelectBuilder(schema, sql.getSQL(), true).select())
{
exportSettingsToTSV(vf, results, getSettingsFileName(), getTableName());
}
Expand Down Expand Up @@ -188,7 +188,7 @@ public void exportSettings(VirtualFile vf, Container container, User user) throw
.append(TargetedMSManager.getTableInfoRuns(), "runs")
.append(" ON replicate.RunId = runs.Id");

try (Results results = QueryService.get().selectResults(schema, sql.getSQL(), null, null, true, true))
try (Results results = QueryService.get().getSelectBuilder(schema, sql.getSQL(), true).select())
{
exportSettingsToTSV(vf, results, getSettingsFileName(), getTableName());
}
Expand Down
Loading