Skip to content

Continue enhancing SQL protections#7707

Open
labkey-jeckels wants to merge 3 commits into
developfrom
fb_sqlProtections
Open

Continue enhancing SQL protections#7707
labkey-jeckels wants to merge 3 commits into
developfrom
fb_sqlProtections

Conversation

@labkey-jeckels
Copy link
Copy Markdown
Contributor

@labkey-jeckels labkey-jeckels commented May 30, 2026

Rationale

Robust SQL generation is important. Code cleanup and consolidation is nice too.

Changes

  • Make previous checks mandatory instead of being gated behind experimental flag (defaulting to being enforced)
  • Introduce new set of checks behind a deprecated flag
    • Potentially malformed strings or numbers
    • Pivot values
  • Handle special characters in stored procedure names
  • Use SQLFragment instead of String for stored procedure calls
  • Misc lint cleanup

Tasks 📍

  • Claude Code Review
  • Manual Testing ?
  • Test Automation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant