Skip to content

Bump certifi from 2017.11.5 to 2022.12.7#14

Open
dependabot[bot] wants to merge 1 commit into
masterfrom
dependabot/pip/certifi-2022.12.7
Open

Bump certifi from 2017.11.5 to 2022.12.7#14
dependabot[bot] wants to merge 1 commit into
masterfrom
dependabot/pip/certifi-2022.12.7

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Dec 7, 2022

Copy link
Copy Markdown
Contributor

Bumps certifi from 2017.11.5 to 2022.12.7.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [certifi](https://github.com/certifi/python-certifi) from 2017.11.5 to 2022.12.7.
- [Release notes](https://github.com/certifi/python-certifi/releases)
- [Commits](certifi/python-certifi@2017.11.05...2022.12.07)

---
updated-dependencies:
- dependency-name: certifi
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added the dependencies Pull requests that update a dependency file label Dec 7, 2022
@JonathanPorta

Copy link
Copy Markdown
Owner

PR Review

Summary

This PR only bumps certifi from 2017.11.5 to 2022.12.7 in the package's runtime requirements.txt. The isolated certifi bump is not the immediate compatibility problem, but the PR is stale and the surrounding dependency set is already not installable with a modern resolver.

Findings

  • Severity: Important
  • Location: requirements.txt
  • Problem: The proposed target, certifi==2022.12.7, is no longer current; PyPI reports certifi 2026.5.20 as latest. More importantly, the same requirements.txt already pins requests==2.20.0 with urllib3==1.26.5, while requests 2.20.0 requires urllib3<1.25.
  • Why it matters: Merging this old certifi-only PR would not produce a validated or internally consistent runtime dependency set. It leaves the package install path broken and does not get the repo to a current security baseline.
  • Suggested fix: Close this stale dependabot PR and replace it with a coordinated refresh of requests/urllib3/certifi plus package-install validation. If the project still needs Python 3.6 compatibility, choose versions that support that runtime explicitly.

Test / Verification Notes

I inspected the PR diff, requirements.txt, the Makefile packaging path, and unpack.py. A focused resolver check for requests==2.20.0 plus certifi==2022.12.7 succeeds if pip is allowed to choose a compatible urllib3, so the certifi bump itself is not conflicting. The full pip install --dry-run -r requirements.txt fails first on the old safe-extractor==0.0.9 source build under the host Python, and a focused check of the already-pinned pair requests==2.20.0 / urllib3==1.26.5 reports ResolutionImpossible because requests requires urllib3<1.25. I also checked PyPI metadata with pip index versions certifi, which reports 2026.5.20 as latest.

Overall Recommendation

Needs changes before merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant