Fix review markers, Rhiza link and PDF metadata - #3
Merged
Conversation
The red colouring added in 3e8e898 marked the day's additions for review, but it ships in the published PDF, where a reader has no way to read it as anything but emphasis or an unfinished draft. The three passages (the prior-art footnote, the reconciliation passage and the Build or Buy section) become plain body text. The "Rhiza was built on a different premise" link pointed at rhiza-education, the curriculum, rather than at the tool itself. Set pdftitle and pdfauthor so the distributed PDF carries a title and an author rather than showing up as vision.pdf with no metadata. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR makes three mechanical LaTeX updates to vision.tex to improve the published PDF’s presentation and correctness without changing the document’s prose.
Changes:
- Adds
pdftitleandpdfauthorto the existing\hypersetupblock so the generated PDF includes title/author metadata. - Removes
\color{red}review-marker wrapping from the prior-art footnote and two marked sections so the public PDF no longer renders red “draft” text. - Fixes the Rhiza hyperlink to point to
Jebel-Quant/rhizainstead ofJebel-Quant/rhiza-education.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three mechanical fixes to
vision.tex. No prose changes — every sentence is untouched.1. The red review markers ship in the published PDF
3e8e898("Mark today's additions in red") wrapped three passages in\color{red}:That works as a marker for a reviewer who knows the convention, but the CI job publishes
vision.pdfto gh-pages on every push tomain, so a reader arriving at the public URL sees red text with no way to interpret it as anything other than emphasis or an unfinished draft. Build or Buy is one of the strongest sections in the document to have flagged that way. This restores all three to plain body text.If the intent was to keep the marking for a while longer, the alternative is a line under the byline explaining the convention — happy to do that instead.
2. The Rhiza link pointed at the curriculum
In Keeping the Platform Consistent, "Rhiza was built on a different premise: scaffolding is not a one-time generation but a continuous synchronisation" linked to
Jebel-Quant/rhiza-education. A reader following the argument about continuous sync landed on lesson material. Now points atJebel-Quant/rhiza.3. The PDF had no title or author metadata
\author{}is empty and there is no\title, so the distributed PDF carried no document title — it presents asvision.pdfin browser tabs, reference managers and anywhere it gets forwarded. Addspdftitleandpdfauthorto the existing\hypersetupblock. Nothing renders differently on the page.Verification
Built locally with the same command and flags CI uses (
xelatex -halt-on-error -interaction=nonstopmode, twice): compiles clean, 14 pages, unchanged from before. Confirmed no\color{red}and norhiza-educationremain, and that the built PDF's Info dictionary now carriesTitle = A Technology Vision for Quantitative TradingandAuthor = Thomas Schmelzer.🤖 Generated with Claude Code