[wip] add waiventure db definitions#164
Open
odrling wants to merge 1 commit into
Open
Conversation
Had a note lying around with that to add, I implemented it so I can `rm` it. RETIRED is badly defined and should probably be computed from “status == WAICOLLE + season set to any value” (I think “retired” heroes were meant to come back in the user’s waicolle collages/collections, but we should check). Also there’s no endpoint to set the status/season in this commit it just adds the fields without breaking anything (hopefully).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had a note lying around with that to add, I implemented it so I can
rmit.RETIRED is badly defined and should probably be computed from “status == WAICOLLE + season set to any value” (I think “retired” heroes were meant to come back in the user’s waicolle collages/collections, but we should check).
Also there’s no endpoint to set the status/season in this commit it just adds the fields without breaking anything (hopefully).