ci: only run check-dist on branch pushes, not tags#94
Merged
Conversation
A bare `on: push` also fired check-dist for tag pushes, re-running an old tag's (possibly failing) workflow. Restrict to branch pushes; the `**` pattern still matches Dependabot's slashed branch names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bare
on: pushtriggered check-dist on tag pushes too, which re-ran old tags' workflows (e.g. the v1.1.0 tag's failing svgexport run). Scope the trigger to branch pushes (branches: ['**']still matches Dependabot's slashed branches; main and feature branches unaffected). Tags no longer trigger check-dist.