chore: replace svgexport with @resvg/resvg-js for icon PNGs#93
Merged
Conversation
svgexport@0.4.2 is unmaintained and pins puppeteer 3.x, whose bundled Chromium no longer launches and which cannot drive modern Chrome, so the icon generation failed in CI. Replace it with @resvg/resvg-js, a browserless SVG renderer, driven by assets/render-icons.js. Regenerate the 9 icon PNGs and run the step in check-dist so they stay in sync and auto-commit alongside dist/. Removes puppeteer from the dependency tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
npm run svg(icon SVG→PNG generation) was broken:svgexport@0.4.2is unmaintained and pinspuppeteer 3.x, whose bundled Chromium no longer launches — and which can't drive a modern Chrome either (verified:Protocol error: Target closedagainst Chrome 149). This is whysvgwas dropped from CI earlier.Change
svgexportwith@resvg/resvg-js— a browserless SVG renderer (prebuilt native binaries, no Chromium, no compilation). Newassets/render-icons.jsrenders everyassets/*.svgto a 64×64 PNG.check-dist(npm run svg && npm run package) so icon PNGs regenerate and auto-commit via the deploy key when an SVG changes — same hands-off flow asdist/.puppeteerfrom the dependency tree entirely (0 references in the lockfile).Verified
npm ci(so CI reproduces the committed PNGs — no auto-commit churn).lint,format:check, andjestall pass;dist/is unaffected.