Skip to content

ci: push auto-built dist via deploy key (enables runtime-dep auto-merge)#91

Merged
JChrist merged 1 commit into
mainfrom
ci/dist-autobuild-deploy-key
Jun 22, 2026
Merged

ci: push auto-built dist via deploy key (enables runtime-dep auto-merge)#91
JChrist merged 1 commit into
mainfrom
ci/dist-autobuild-deploy-key

Conversation

@JChrist

@JChrist JChrist commented Jun 22, 2026

Copy link
Copy Markdown
Owner

Why

Dev-dependency PRs auto-merge fine because they don't change dist/. Runtime-dependency PRs (axios, etc.) do change dist/: check-dist rebuilds it and commits to the PR branch, but that commit is pushed with GITHUB_TOKEN, which does not start new workflow runs. So the required checks (JavaScript Tests, GitHub Actions Test) never re-run on the new head, branch protection keeps blocking, and native auto-merge stalls.

Change

check-dist now pushes the rebuilt dist/ using a dedicated dist-auto-build deploy key (private key in the DIST_DEPLOY_KEY Actions + Dependabot secret) instead of GITHUB_TOKEN. A deploy-key push re-triggers CI on the new commit, the required checks pass on the new head, and auto-merge completes — dist/ and the dependency bump land together.

The key is referenced only by the push step (not during npm ci/build), and only runs on source branches (never protected main).

Notes

  • Self-terminating: the pushed dist/ commit re-runs check-dist, which finds dist/ already in sync → no further commit.
  • Dropped the unverified ephemeral-key commit signing (signatures aren't required by branch protection).

Pushing the rebuilt dist/ with GITHUB_TOKEN does not start new workflow
runs, so the required checks never re-run on the new commit and native
auto-merge stalls on runtime-dependency PRs that change dist/. Push with
the dist-auto-build deploy key instead, which re-triggers CI and lets
auto-merge complete.
@JChrist JChrist merged commit b57729a into main Jun 22, 2026
6 checks passed
@JChrist JChrist deleted the ci/dist-autobuild-deploy-key branch June 22, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant