feat: add github billing plan to org spec#10
Conversation
vince-vibin
force-pushed
the
feat/non-enterprise
branch
from
0e024a9 to
532f6ae
Compare
vince-vibin
force-pushed
the
feat/non-enterprise
branch
from
532f6ae to
af5abca
Compare
vince-vibin
force-pushed
the
feat/non-enterprise
branch
from
364f9bb to
b0d61a9
Compare
|
adresses #6 |
tstollin
left a comment
tstollin
left a comment
There was a problem hiding this comment.
For requested changes, please refer to the comments.
Additionally, please squash all commits related to the new feature into a single commit and bundle the go 1.26 update related changes (for example switch to usage of new(...)) into a second commit.
This will keep the Releases page entry focussed after release.
| if len(organization.Spec.RulesetPresetList) > 0 { | ||
| errs = append(errs, field.Forbidden( | ||
| specPath.Child("rulesetPresets"), | ||
| fmt.Sprintf("organization rulesets require the 'enterprise' plan, but plan is '%s'", plan), |
There was a problem hiding this comment.
did you test this? the api docs for the free plan suggest otherwise: https://docs.github.com/en/rest/orgs/rules?apiVersion=2026-03-10#create-an-organization-repository-ruleset
There was a problem hiding this comment.
what do the changes to this file intend to achieve? the Workflow updates the CRDs AND the appVersion
There was a problem hiding this comment.
this came due to the update i have already rolled back the changes in the latest commit when i squash these changes will be removed
vince-vibin
force-pushed
the
feat/non-enterprise
branch
from
8a895a6 to
fbf846d
Compare
vince-vibin
force-pushed
the
feat/non-enterprise
branch
12 times, most recently
from
a710ef7 to
f5dce18
Compare
vince-vibin
force-pushed
the
feat/non-enterprise
branch
3 times, most recently
from
f643dab to
9ad3819
Compare
vince-vibin
force-pushed
the
feat/non-enterprise
branch
from
9ad3819 to
ac3ec2f
Compare
|
closing in favour of #12 |
2 participants
No description provided.