[chore] prep for v1.20 injective-core release#416
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughFinalize v1.15.0, update build inputs to Injective core v1.20.0 and Indexer v1.20.2, add StreamABCIEvents RPC, regenerate protobuf/grpc descriptors, refresh OFAC data, and update tests to match new response fields. ChangesRelease v1.15.0 with Indexer Integration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRsPoem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
buf.gen.yaml (1)
25-27: 💤 Low valueStale commented-out input block. The disabled
injective-corechainlink branch entry is dead config; consider removing it now that core is pinned tov1.20.0on Line 22-23.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@buf.gen.yaml` around lines 25 - 27, Remove the stale commented-out git_repo block for InjectiveLabs/injective-core (the three-line block starting with "# - git_repo: https://github.com/InjectiveLabs/injective-core" and its branch/subdir entries) since core is pinned to v1.20.0 and this dead Chainlink branch entry is no longer needed; simply delete those commented lines to clean up buf.gen.yaml.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@buf.gen.yaml`:
- Around line 18-19: In buf.gen.yaml, clarify why cometbft is pinned to tag
"v1.0.1-inj.v1.19.0-rollback" (confirm it is the intended upstream source for
injective-core v1.20.0 and add a short comment explaining the v1.19 rollback
reason), verify the cosmos-sdk pin "v0.50.14-inj.10" is correct, and remove the
stale commented-out injective-core chainlink block (or re-enable it with the
correct branch/tag if it’s actually required); update the surrounding comments
to state the rationale for the cometbft rollback tag and whether injective-core
v1.20.0 depends on that specific fork.
---
Nitpick comments:
In `@buf.gen.yaml`:
- Around line 25-27: Remove the stale commented-out git_repo block for
InjectiveLabs/injective-core (the three-line block starting with "# - git_repo:
https://github.com/InjectiveLabs/injective-core" and its branch/subdir entries)
since core is pinned to v1.20.0 and this dead Chainlink branch entry is no
longer needed; simply delete those commented lines to clean up buf.gen.yaml.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 4faaaef0-4ed9-41ae-ae5a-9fbde272b4c6
📒 Files selected for processing (14)
CHANGELOG.mdMakefilebuf.gen.yamlpyinjective/ofac.jsonpyinjective/proto/exchange/event_provider_api_pb2.pypyinjective/proto/exchange/event_provider_api_pb2_grpc.pypyinjective/proto/exchange/injective_accounts_rpc_pb2.pypyinjective/proto/exchange/injective_chart_rpc_pb2.pypyinjective/proto/exchange/injective_derivative_exchange_rpc_pb2.pypyinjective/proto/exchange/injective_rfq_rpc_pb2.pypyinjective/proto/exchange/injective_tc_derivatives_rpc_pb2.pypyproject.tomltests/client/indexer/grpc/test_indexer_grpc_derivative_api.pytests/client/indexer/stream_grpc/test_indexer_grpc_derivative_stream.py
Comment on lines
18
to
+19
| - git_repo: https://github.com/InjectiveLabs/cometbft | ||
| tag: v1.0.1-inj.7 | ||
| tag: v1.0.1-inj.v1.19.0-rollback |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Confirm the pinned cometbft tag exists
git ls-remote --tags https://github.com/InjectiveLabs/cometbft.git | grep -i 'v1.0.1-inj'Repository: InjectiveLabs/sdk-python
Length of output: 1066
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Show buf.gen.yaml around the referenced lines
ls -la
if [ -f buf.gen.yaml ]; then
nl -ba buf.gen.yaml | sed -n '1,120p'
else
echo "buf.gen.yaml not found in repo root"
fiRepository: InjectiveLabs/sdk-python
Length of output: 1886
🏁 Script executed:
#!/bin/bash
set -euo pipefail
if [ -f buf.gen.yaml ]; then
cat -n buf.gen.yaml | sed -n '1,120p'
else
echo "buf.gen.yaml not found in repo root"
fiRepository: InjectiveLabs/sdk-python
Length of output: 1216
Clarify the cometbft -rollback pin and clean up stale commented config
buf.gen.yamlpinscometbfttov1.0.1-inj.v1.19.0-rollback(lines 18-19); the tag exists upstream, but confirm this is the intended source forinjective-corev1.20.0(document whyv1.19.0/-rollbackis used).cosmos-sdkis pinned tov0.50.14-inj.10(line 21), matching the expected minor bump.- The commented-out
injective-corechainlink block (lines 25-27) remains; remove it if obsolete or re-enable it with the correct branch control.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@buf.gen.yaml` around lines 18 - 19, In buf.gen.yaml, clarify why cometbft is
pinned to tag "v1.0.1-inj.v1.19.0-rollback" (confirm it is the intended upstream
source for injective-core v1.20.0 and add a short comment explaining the v1.19
rollback reason), verify the cosmos-sdk pin "v0.50.14-inj.10" is correct, and
remove the stale commented-out injective-core chainlink block (or re-enable it
with the correct branch/tag if it’s actually required); update the surrounding
comments to state the rationale for the cometbft rollback tag and whether
injective-core v1.20.0 depends on that specific fork.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Chores
Tests