Update page url when hash changes#1105
Merged
Merged
Conversation
|
Member
|
@duonglaiquang this requires some time because i have some memories that i had hard times with this. Will have a look at this during the next days... |
rbri
force-pushed
the
master
branch
2 times, most recently
from
2d7d378 to
96efc56
Compare
Member
|
Sorry, this got lost on my stack for version 5.0.0. But i fear i will make a 5.1.0 soon. |
Member
|
merged, also duplicate your test as webdriver tests. All works fine. Thanks as always |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following
Fix
Location.setHash()to update the page'sWebRequestURL when the hash changes, ensuringpage.getUrl()reflects the current hashFix
WebClient.makeWebResponseForAboutUrl()to properly handleabout:blankwith hash fragments (e.g.,about:blank#foo) instead of throwingMalformedURLException