Skip to content

add PacketOrderQ#2521

Open
thelema1337 wants to merge 1 commit into
GrimAnticheat:2.0from
thelema1337:packetorder-q
Open

add PacketOrderQ#2521
thelema1337 wants to merge 1 commit into
GrimAnticheat:2.0from
thelema1337:packetorder-q

Conversation

@thelema1337
Copy link
Copy Markdown

We shouldn't allow players to cancel transaction packets while they're moving. This check is a complete inversion of BadPafcketsR. You can still be detected by TransactionOrder for canceling transactions, but I decided to add a check to completely fix some bypass.

@SamB440
Copy link
Copy Markdown
Contributor

SamB440 commented Mar 5, 2026

This isn’t a vanilla compatible check. If a player’s connection freezes inbound for two seconds this will false flag.

@Axionize
Copy link
Copy Markdown
Contributor

Axionize commented Mar 5, 2026

@SamB440 BadPacketsR does the some thing though and its already in Grim. Should we make both checks configurable similar to the 1k ping limit used by TimerLimit?

@ManInMyVan
Copy link
Copy Markdown
Contributor

I don't think this should be a packetorder check

@SamB440
Copy link
Copy Markdown
Contributor

SamB440 commented Mar 10, 2026

BadpacketsR was added to fix a memory "leak" exploit, TimerLimit was added to fix a bypass, if we start adding checks like this we should reconsider approvable PRs and the naming of such checks

@thelema1337
Copy link
Copy Markdown
Author

Функция BadpacketsR была добавлена ​​для исправления уязвимости, связанной с «утечкой» памяти, функция TimerLimit была добавлена ​​для исправления обходной уязвимости. Если мы начнем добавлять подобные проверки, нам следует пересмотреть допустимые запросы на слияние и названия таких проверок.

What should it be called? Surely it shouldn't be TransactionOrderA and B? The check also verifies position packets; it's not just a dumb detection if the player doesn't respond to transactions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants