add PacketOrderQ#2521
Conversation
|
This isn’t a vanilla compatible check. If a player’s connection freezes inbound for two seconds this will false flag. |
|
@SamB440 BadPacketsR does the some thing though and its already in Grim. Should we make both checks configurable similar to the 1k ping limit used by TimerLimit? |
|
I don't think this should be a packetorder check |
|
BadpacketsR was added to fix a memory "leak" exploit, TimerLimit was added to fix a bypass, if we start adding checks like this we should reconsider approvable PRs and the naming of such checks |
What should it be called? Surely it shouldn't be TransactionOrderA and B? The check also verifies position packets; it's not just a dumb detection if the player doesn't respond to transactions. |
We shouldn't allow players to cancel transaction packets while they're moving. This check is a complete inversion of BadPafcketsR. You can still be detected by TransactionOrder for canceling transactions, but I decided to add a check to completely fix some bypass.