feat: add enhanced mentions#3189
Open
MartinCupela wants to merge 6 commits into
Open
Conversation
# Conflicts: # src/components/Message/__tests__/__snapshots__/MessageText.test.tsx.snap # src/components/Message/renderText/rehypePlugins/mentionsMarkdownPlugin.ts # src/components/Message/renderText/renderText.tsx
MartinCupela
force-pushed
the
feat/enhanced-mentions
branch
from
b154ab1 to
8bc5ceb
Compare
oliverlaz
reviewed
Jun 1, 2026
Comment on lines
+39
to
+49
| const LeadingSlot = useMemo( | ||
| () => | ||
| function BroadcastMentionLeadingSlot() { | ||
| return ( | ||
| <div className='str-chat__suggestion-list__mention-item-leading-slot'> | ||
| <IconMegaphone className='str-chat__suggestion-list__mention-item-leading-slot-icon' /> | ||
| </div> | ||
| ); | ||
| }, | ||
| [], | ||
| ); |
Member
There was a problem hiding this comment.
IMO, it would be much cleaner if we made this a top-level component. There are other cases like this, too.
|
|
||
| // JSX cannot type-check a generic intrinsic element with generic root props here. | ||
| // Call sites still get RootElement-specific rootProps; createElement keeps rendering simple internally. | ||
| return React.createElement( |
Member
There was a problem hiding this comment.
Comment on lines
+47
to
+50
| const displayTitle = useMemo( | ||
| () => <TokenizedSuggestionParts tokenizedDisplayName={entity.tokenizedDisplayName} />, | ||
| [entity.tokenizedDisplayName], | ||
| ); |
Member
There was a problem hiding this comment.
This is something that react-compiler can optimize automatically for us.
MartinCupela
force-pushed
the
feat/enhanced-mentions
branch
from
f59965d to
70241a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Depends on: GetStream/stream-chat-js#1743
Closes REACT-979
This PR brings enhanced mentions support to
stream-chat-reactacross both the composer UI and rendered message text.It updates the
@suggestion flow to render a mixed mention set fromstream-chat-js, including direct users, built-in mentions like@channeland@here, roles, and user groups. The suggestion list now uses dedicated row components for each mention type, keeps keyboard navigation working across non-user items, and preserves accessibility and i18n behavior for the mixed result set.It also extends the message text rendering pipeline so enhanced mentions are highlighted the same way direct user mentions are. The
renderTextpath now accepts additive mention metadata, routes all mention kinds through a unifiedmentionrenderer contract vianode.mentionedEntity, and keeps backward compatibility for older user-only mention consumers through the deprecatednode.mentionedUseralias and the existingrenderText(text, mentioned_users, options)signature.Finally, the PR adds focused regression coverage for render-text behavior, quoted-message rendering, backward-compatible plugin usage, email-like mention edge cases, and multi-word mention names.
Highlights
@suggestion results fromstream-chat-js:@channel@hereMentionItemSpecialMentionItemRoleItemUserGroupItemUserItembackward compatibility for existing consumersrenderTextto support additive mention metadata throughoptions.messageMentionEntitiesmention+node.mentionedEntitynode.mentionedUsermentionsMarkdownPlugin(UserResponse[])renderText(text, mentioned_users, options)